fix surface sat vap pressure, remove T_freeze overwrite #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes seem rather large... |
yes. I'm wondering if there is some other cause for it. I'll check if for this version qt is exactly zero, and compare with the qt profile from main. |
|
if I am not wrong they still don't reproduce all changes you had in the big free PR, right ? |
trontrytel
force-pushed
the
aj/test_freezing
branch
from
45d0090
to
a83e281
Compare
trontrytel
changed the title
yairchn
approved these changes
Oct 19, 2021
Hopefully we will be able to test a better root solver soon |
ilopezgp
approved these changes
Oct 19, 2021
charleskawczynski
approved these changes
Oct 19, 2021
|
|
trontrytel
force-pushed
the
aj/test_freezing
branch
from
1a663a0
to
2ed3649
Compare
|
bors r+ |
|
Build succeeded: |
charleskawczynski
referenced
this pull request
Oct 25, 2021
449: Bump version for new release r=charleskawczynski a=charleskawczynski Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
T_freezeoverwrite for all cases exceptTRMMandGATE.It also replaces the surface saturation vapour pressure calculation that assumed liquid only, with one that assumes phase partitioning depending on temperature.